Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fish: fix fenv function path #288

Merged
merged 1 commit into from
Feb 17, 2021
Merged

fish: fix fenv function path #288

merged 1 commit into from
Feb 17, 2021

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Feb 5, 2021

Necessary as of NixOS/nixpkgs@d94921d

@r-burns
Copy link
Contributor Author

r-burns commented Feb 5, 2021

Hmm I wasn't aware of #270 when I opened this, but that didn't address this specific issue. I'm on nixpkgs master, and unless I use this fix, fish tries to use the old incorrect fenv function path and fails to set up my environment properly. Maybe anyone still using fenv (not babelfish) hadn't encountered this issue yet, because #283 needed to be addressed first?

LnL7
LnL7 approved these changes Feb 17, 2021
View reviewed changes
Copy link
Owner

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty ugly, but I guess there's not really a nice solution for this.

@LnL7 LnL7 merged commit 034600c into LnL7:master Feb 17, 2021
@r-burns r-burns deleted the fish-fenv branch February 17, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-burns @LnL7